On Tue, 23 Jun 2009 06:36:10 +0200, Dai Ngo <Dai.Ngo at sun.com> wrote:
> Thank you Mahesh, Robert and Frank for reviewing the change > and providing feedback. Below is the updated webrev: > > http://cr.opensolaris.org/~dain/6216670-3/ > <http://cr.opensolaris.org/%7Edain/6216670-3/> > > There is no logic change from the previous webrev. The update > reflects changes include a correction of filename in a comment line > and rename of dtrace probes. still looks good to me. minor nit still, you are very inconsistent in your forward function declarations, some time you use type and a variable name, the next function does only contain the type and so forth. you should make this consistent, ie. in header files we usually omit a variable name by style definition, we do so usually as well for static forward declaration in the .c file itself. thanks frankB
