On Mon, 29 Jun 2009 22:28:48 +0200, Dai Ngo <Dai.Ngo at sun.com> wrote:
> Frank Batschulat (Home) wrote: >> still looks good to me. >> >> minor nit still, you are very inconsistent in your forward function >> declarations, some time you use type and a variable name, the next function >> does only contain the type and so forth. >> >> you should make this consistent, ie. in header files we usually omit >> a variable name by style definition, we do so usually as >> well for static forward declaration in the .c file itself. >> > I made the changes to address the minor nits you pointed out. > > Webrev is updated: > > http://cr.opensolaris.org/~dain/6216670-4/ > <http://cr.opensolaris.org/%7Edain/6216670-4/> Yepp, thanks, ship it! --- frankB
