Thanks for the efforts. In general I like the checks we have enabled. Occasionally one creates annoyance and my decision is to live with an occasional annoyance. This particular file shouldn't see too much changes and now that it's 99% fixed, we can easily move past the one or two annoyances that may crop up.
Frank > -----Original Message----- > From: William Allen Simpson [mailto:william.allen.simp...@gmail.com] > Sent: Wednesday, February 21, 2018 2:29 PM > To: Frank Filz <ffilz...@mindspring.com>; 'NFS Ganesha Developers' <nfs- > ganesha-de...@lists.sourceforge.net> > Subject: Re: [Nfs-ganesha-devel] inconsistent '*' spacing > > On 2/21/18 8:28 AM, William Allen Simpson wrote: > > Anyway, I'll try to push a patch for those 2 files by tomorrow. > > ERROR: "foo * bar" should be "foo *bar" > #18656: FILE: src/include/nfsv41.h:9900: > +static inline bool xdr_CB_COMPOUND4res(XDR * xdrs, > > total: 450 errors, 14 warnings, 18658 lines checked > > If those are fixed, we have remaining: > > ERROR: need consistent spacing around '*' (ctx:WxV) > #4757: FILE: src/include/nfsv41.h:3696: > +extern COMPOUND4res *nfsproc4_compound_4(COMPOUND4args *, CLIENT > *); > ^ > > ERROR: need consistent spacing around '*' (ctx:WxV) > #4795: FILE: src/include/nfsv41.h:3719: > +extern CB_COMPOUND4res *cb_compound_1(CB_COMPOUND4args *, > CLIENT *); > ^ > > total: 7 errors, 14 warnings, 18659 lines checked > > > And no way around many of them, since fixing this: > > WARNING: Avoid multiple line dereference - prefer 'objp- > >nad_new_entry_cookie.nad_new_entry_cookie_val' > #13467: FILE: src/include/nfsv41.h:9151: > + (char **)&objp->nad_new_entry_cookie. > + nad_new_entry_cookie_val, > > WARNING: Avoid multiple line dereference - prefer 'objp- > >nad_new_entry_cookie.nad_new_entry_cookie_len' > #13469: FILE: src/include/nfsv41.h:9153: > + (u_int *) &objp->nad_new_entry_cookie. > + nad_new_entry_cookie_len, 1, sizeof(nfs_cookie4), > > changes to a complaint about too long line: > > WARNING: line over 80 characters > #13466: FILE: src/include/nfsv41.h:9150: > + (char **)&objp- > >nad_new_entry_cookie.nad_new_entry_cookie_val, > > WARNING: line over 80 characters > #13467: FILE: src/include/nfsv41.h:9151: > + (u_int *) > +&objp->nad_new_entry_cookie.nad_new_entry_cookie_len, > > So un-indented the whole thing to make more room. > > But even that won't fix: > > WARNING: line over 80 characters > #9587: FILE: src/include/nfsv41.h:6149: > + &objp- > >open_none_delegation4_u.ond_server_will_signal_avail)) > > WARNING: line over 80 characters > #11239: FILE: src/include/nfsv41.h:7261: > + > +&objp- > >GET_DIR_DELEGATION4res_non_fatal_u.gddrnf_will_signal_deleg_avai > +l)) > > > There are irredeemable errors, because checkpatch won't allow K&R C, but the > #ifdef __STDC__ #else doesn't actually compile these lines: > > ERROR: Bad function definition - int nfs4_program_4_freeresult() should > probably be int nfs4_program_4_freeresult(void) > #4773: FILE: src/include/nfsv41.h:3708: > +extern int nfs4_program_4_freeresult(); > > ERROR: Bad function definition - int nfs4_callback_1_freeresult() should > probably be int nfs4_callback_1_freeresult(void) > #4812: FILE: src/include/nfsv41.h:3731: > +extern int nfs4_callback_1_freeresult(); > > total: 4 errors, 2 warnings, 18577 lines checked > > Would have been much easier to turn off this pointless check!!! ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
