On 2/21/18 11:35 AM, Frank Filz wrote:
There's a -n or --no-verify option that will bypass the commit hooks. I suggest
trying to commit without that first to make sure the only checkpatch
errors/warnings are for the spacing around * and then commit again with -n to
bypass checkpatch to actually commit.
Boy oh boy, I wish I'd known about that!!!
So that's what I've done on the nfs41.h formatting.
I've also removed the K&R-style definitions that checkpatch hates.
I suppose now that it seems to complain either way, we can fix them
all to not have the space, and just force the commit and ignore the
checkpatch warnings (when I see ONLY warnings for things I know we
can't/won't fix in gerrithub, I ignore them and merge anyway). I'm not
sure how much of a potential merge headache changing them all would
cause though. I don't think nfsv41.h gets changed all that much so
even if we had to backport something, the potential manual merge wouldn't
be awful.
New -dev cycle, so it's time.
Yes, this is the right time to do it.
[...] > I sympathize with your grumbling about this one... I've chosen
the set of checkpatch checks to enable based on what seems to work
best for our code and keeps us as consistent style as possible. I
realize some folks have preferences opposite some of the checks, but
our code style is now what it is...
Or not, as in this case.
Anyway, I'll try to push a patch for those 2 files by tomorrow.
Ok, thanks
Turned out nfs23.h hadn't been updated into inlines for performance,
so doesn't seem to have these strange errors. Hopefully nobody else
will want to patch nfs41.h this week.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
