I don't like the idea of having a namespace containing a single ILogger type...
On Sep 18, 11:30 pm, Tuna Toksoz <[email protected]> wrote: > Even if the cause is somehow remediable in other way, the solution is > reasonable. moving it to Diagnostics/Logging/Logger wouldn't hurt and is a > good idea. > > Tuna Toksöz > Eternal sunshine of the open source mind. > > http://devlicio.us/blogs/tuna_toksozhttp://tunatoksoz.comhttp://twitter.com/tehlike > > > > On Sat, Sep 18, 2010 at 11:28 AM, Roelof Blom <[email protected]> wrote: > > Exactly the constructive answer you'd expect these days from NH's lead. > > > So, what about it? The request is trivial, and Henry will supply a patch. > > > -- Roelof > > > Op 18 sep. 2010 om 17:15 heeft Fabio Maulo <[email protected]> het > > volgende geschreven: > > > Perhaps I should send the same request to Microsoft .NET team because they > > have used ISet. > > > On Sat, Sep 18, 2010 at 9:39 AM, Johannes Gustafsson <<[email protected]> > > [email protected]> wrote: > > >> +1 > > >> I have the same problem where it conflicts with our own ILogger interface. > >> I guess NHibernate.ILogger should not be used outside NH anyway (except for > >> contrib and NHibernate.* libs) so hiding it in a deeper namespace is a good > >> idea IMHO. > > >> /Johannes > > >> 2010/9/18 Henry Conceição < <[email protected]> > >> [email protected]> > > >> Hi, > > >>> While I was updating one of my projects to NHibernate 3 alpha 2, I did > >>> notice that the ILogger interface is placed directly under the > >>> NHibernate root namespace. Although I think that the abstraction is a > >>> good thing, it's too exposed and conflicts with any other ILogger > >>> (Castle's one for example) out there. > > >>> That been said, I want to know if it's possible to move it to a more > >>> internal namespace, like NHibernate.Logging or something like that. If > >>> the asnwer is yes, I'll be happy to provide a patch for that. > > >>> Cheers, > >>> Henry Conceição > > > -- > > Fabio Maulo
