You did not explicitly say something about Henry's proposal, no. But implicitly, to me at least, you did with the ISet remark. I apoligize if my response came out rude.
Seems like the parallel conversation on twitter about this subject was meant as a more philosophical thing, although it had a strangely tone. Again, my perception perhaps. Anyway, as ILogger exists in both NH and Castle.Core it's causing friction. As both frameworks are frequently used together we must and can resolve this. NH's variant being much younger and therefore suspected to cause much less breakage was the source of the request to move it IMHO. -- Roelof (a Castle project committer) Op 18 sep. 2010 om 17:32 heeft Fabio Maulo <[email protected]> het volgende geschreven: > again another erudite. > I didn't say nothing about Henry proposal and you are saying something to me. > Who you are ? > > IMO there is no problem just because it is one minute fix, using Resharper, > renaming the interface. > > On Sat, Sep 18, 2010 at 12:28 PM, Roelof Blom <[email protected]> wrote: > Exactly the constructive answer you'd expect these days from NH's lead. > > So, what about it? The request is trivial, and Henry will supply a patch. > > -- Roelof > > Op 18 sep. 2010 om 17:15 heeft Fabio Maulo <[email protected]> het > volgende geschreven: > >> Perhaps I should send the same request to Microsoft .NET team because they >> have used ISet. >> >> On Sat, Sep 18, 2010 at 9:39 AM, Johannes Gustafsson <[email protected]> >> wrote: >> +1 >> >> I have the same problem where it conflicts with our own ILogger interface. I >> guess NHibernate.ILogger should not be used outside NH anyway (except for >> contrib and NHibernate.* libs) so hiding it in a deeper namespace is a good >> idea IMHO. >> >> /Johannes >> >> 2010/9/18 Henry Conceição <[email protected]> >> >> Hi, >> >> While I was updating one of my projects to NHibernate 3 alpha 2, I did >> notice that the ILogger interface is placed directly under the >> NHibernate root namespace. Although I think that the abstraction is a >> good thing, it's too exposed and conflicts with any other ILogger >> (Castle's one for example) out there. >> >> That been said, I want to know if it's possible to move it to a more >> internal namespace, like NHibernate.Logging or something like that. If >> the asnwer is yes, I'll be happy to provide a patch for that. >> >> Cheers, >> Henry Conceição >> >> >> >> >> -- >> Fabio Maulo >> > > > > -- > Fabio Maulo >
