Hi all, I've created a ticket, containing the patch: http://216.121.112.228/browse/NH-2337
Cheers, Henry Conceição On Sat, Sep 18, 2010 at 2:18 PM, Fabio Maulo <[email protected]> wrote: > Oskar, > The solution is not a problem. > The concept is the problem. What .NET gave us, as solution, is namespaces > and probably for that reason MS team does not be to worry about the name of > a class/interface. > Where I'm working with .NET4 and I need ISet of Iesi I have to specify the > namespace using an alias or the full namespace of the class. > Personally I don't have any kind of problem with NH's ILogger in no one of > the projects I'm involved in this moment, where I'll have a problem I'll use > namespaces to disambiguate the interface/class name. > In this case we will do an exception only because Castle is our cousin... > (even if some Castle's committers, not all only some, have not yet > understood) > On Sat, Sep 18, 2010 at 2:49 PM, Oskar Berggren <[email protected]> > wrote: >> >> 2010/9/18 Fabio Maulo <[email protected]>: >> > This is the re-phrasing, of your phrase, about what I mean: >> > Anyway, as ISet exists in both NH and .NET4 it's causing friction. As >> > both >> > frameworks are frequently used together we must and can resolve this. >> > .NET4's variant being much younger and therefore suspected to cause much >> > less breakage was the source of the request to move it IMHO. >> >> Well, you're right about that Fabio, though I guess I would hate it if >> eventually I had to have "using System.Collections.Generic.Sets" >> besides the S.C.G "everywhere", since it seems reasonable to believe >> that the MS ISet will eventually become the more widespread class. >> IMHO of course. >> >> But we are open source, and in general more open and willing to listen >> than MS often appears, and have therefore excellent abilities to >> actually implement the rational solution. :) >> >> Personally I like the idea of putting classes and interfaces that are >> most of the time only used internally by NH or by a specific extension >> implementation in a sub-namespace, so the main namespace is cleaner. >> >> /Oskar >> >> >> > On Sat, Sep 18, 2010 at 1:09 PM, Roelof Blom <[email protected]> >> > wrote: >> >> >> >> You did not explicitly say something about Henry's proposal, no. But >> >> implicitly, to me at least, you did with the ISet remark. I apoligize >> >> if my >> >> response came out rude. >> >> Seems like the parallel conversation on twitter about this subject was >> >> meant as a more philosophical thing, although it had a strangely tone. >> >> Again, my perception perhaps. >> >> Anyway, as ILogger exists in both NH and Castle.Core it's causing >> >> friction. As both frameworks are frequently used together we must and >> >> can >> >> resolve this. NH's variant being much younger and therefore suspected >> >> to >> >> cause much less breakage was the source of the request to move it >> >> IMHO. >> >> >> >> -- Roelof (a Castle project committer) >> >> Op 18 sep. 2010 om 17:32 heeft Fabio Maulo <[email protected]> het >> >> volgende geschreven: >> >> >> >> again another erudite. >> >> I didn't say nothing about Henry proposal and you are saying something >> >> to >> >> me. Who you are ? >> >> IMO there is no problem just because it is one minute fix, using >> >> Resharper, renaming the interface. >> >> >> >> On Sat, Sep 18, 2010 at 12:28 PM, Roelof Blom <[email protected]> >> >> wrote: >> >>> >> >>> Exactly the constructive answer you'd expect these days from NH's >> >>> lead. >> >>> So, what about it? The request is trivial, and Henry will supply a >> >>> patch. >> >>> -- Roelof >> >>> Op 18 sep. 2010 om 17:15 heeft Fabio Maulo <[email protected]> het >> >>> volgende geschreven: >> >>> >> >>> Perhaps I should send the same request to Microsoft .NET team because >> >>> they have used ISet. >> >>> >> >>> On Sat, Sep 18, 2010 at 9:39 AM, Johannes Gustafsson >> >>> <[email protected]> wrote: >> >>>> >> >>>> +1 >> >>>> I have the same problem where it conflicts with our own ILogger >> >>>> interface. I guess NHibernate.ILogger should not be used outside NH >> >>>> anyway >> >>>> (except for contrib and NHibernate.* libs) so hiding it in a deeper >> >>>> namespace is a good idea IMHO. >> >>>> /Johannes >> >>>> >> >>>> 2010/9/18 Henry Conceição <[email protected]> >> >>>>> >> >>>>> Hi, >> >>>>> >> >>>>> While I was updating one of my projects to NHibernate 3 alpha 2, I >> >>>>> did >> >>>>> notice that the ILogger interface is placed directly under the >> >>>>> NHibernate root namespace. Although I think that the abstraction is >> >>>>> a >> >>>>> good thing, it's too exposed and conflicts with any other ILogger >> >>>>> (Castle's one for example) out there. >> >>>>> >> >>>>> That been said, I want to know if it's possible to move it to a more >> >>>>> internal namespace, like NHibernate.Logging or something like that. >> >>>>> If >> >>>>> the asnwer is yes, I'll be happy to provide a patch for that. >> >>>>> >> >>>>> Cheers, >> >>>>> Henry Conceição >> >>>> >> >>> >> >>> >> >>> >> >>> -- >> >>> Fabio Maulo >> >>> >> >> >> >> >> >> >> >> -- >> >> Fabio Maulo >> >> >> > >> > >> > >> > -- >> > Fabio Maulo >> > >> > > > > > -- > Fabio Maulo > >
