The rejected PR <https://github.com/nhibernate/nhibernate-core/pull/604> for this subject I have mentioned in a previous message was supplying some sort of replacement: the feature would have still worked if the user has an explicit reference in his project to Iesi, thanks to some reflection inside NHibernate for the feature.
But introducing such a hidden dependency for a feature, which would bite only at runtime, was considered a bad move. > little used "feature" Who really knows? I know some projects which use it. Apparently Michael Powell does too. P.S.: be careful when replying by email, please purge email addresses. I have got a surge in spam since my email address was published in this group through such a reply in another discussion. Le samedi 18 novembre 2017 23:27:37 UTC+1, Michael Powell a écrit : > > On Sat, Nov 18, 2017 at 4:37 PM, Fabio Maulo wrote: > > NH supports pretty all types of collections through build-in + > > IUserCollectionType. > > All our very old friends Iesi.Collections can be supported by a specific > > NuGet (call it NHibernate.IesiCollectionsSupport). > > > > Should we have a dependency to Iesi just for a codeline ? > > Perhaps? > > > public override object Instantiate(int anticipatedSize) > > { > > return new LinkedHashSet<T>(); > > } > > > > Perhaps we can lose a little used "feature", no ? > > No. At least not without a replacement. > > > On Thu, Nov 16, 2017 at 10:00 PM, Michael Powell > > wrote: > >> > >> FWIW, *that I know of*, I sometimes use ordered sets, *I THINK*, in > >> places. If it's the same collection? I don't know whether it is. It's > >> been a little while for me since I am in another code base ATM. > >> > >> On Thu, Nov 16, 2017 at 7:56 PM, Ricardo Peres wrote: > >> > Hola, Fabio! > >> > > >> > Go for it! Let's kill Iesi.Collection! > >> > > >> > RP > >> > > >> > > >> > On Thursday, November 16, 2017 at 1:11:49 AM UTC, Fabio Maulo wrote: > >> >> > >> >> Hi tobarish, > >> >> > >> >> Can I remove Iesi.Collection dependency ? > >> >> with a PR of course. > >> >> > >> >> @hazzik have you time to help me with some rule about coding style, > >> >> rebase, run-all-tests and/or other rules ? Thanks. > >> >> > >> >> > >> > -- > >> > > >> > --- > >> > You received this message because you are subscribed to the Google > >> > Groups > >> > "nhibernate-development" group. > >> > To unsubscribe from this group and stop receiving emails from it, > send > >> > an > >> > email to nhibernate-development+unsubscr...@googlegroups.com. > >> > For more options, visit https://groups.google.com/d/optout. > >> > >> -- > >> > >> --- > >> You received this message because you are subscribed to the Google > Groups > >> "nhibernate-development" group. > >> To unsubscribe from this group and stop receiving emails from it, send > an > >> email to nhibernate-development+unsubscr...@googlegroups.com. > >> For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > -- > > Fabio Maulo > > T @fabiomaulo > > S fabiomaulo > > > > -- > > > > --- > > You received this message because you are subscribed to the Google > Groups > > "nhibernate-development" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to nhibernate-development+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > -- --- You received this message because you are subscribed to the Google Groups "nhibernate-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to nhibernate-development+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.