On Sat, Nov 18, 2017 at 6:24 PM, Fabio Maulo <fabioma...@gmail.com> wrote:
> Sir, yes sir.
>
> Can we agree about this:
> . The PR should allow the usage of order-by in <set> mapping
> . As all other persistent collection NH may have its own implementation to
> ensure the behavior just when the collection comes from NH
> . The user is responsible to use an ISet implementation that maintains the
> order when he works on its side
> . The PR should pass at least all existing tests
I'd recommend that as long as you're willing to follow through on the
FNH side to ensure feature completeness for any breaking changes, go
for it. Have at it.
Up to and including any unit or integration tests that demonstrate said changes.
I don't personally have the desire or the bandwidth, however.
> Is it ok ?
>
> On Sat, Nov 18, 2017 at 7:14 PM, Michael Powell <x...@gmail.com> wrote:
>>
>> On Sat, Nov 18, 2017 at 4:37 PM, Fabio Maulo <fabioma...@gmail.com> wrote:
>> > NH supports pretty all types of collections through build-in +
>> > IUserCollectionType.
>> > All our very old friends Iesi.Collections can be supported by a specific
>> > NuGet (call it NHibernate.IesiCollectionsSupport).
>> >
>> > Should we have a dependency to Iesi just for a codeline ?
>>
>> Perhaps?
>>
>> > public override object Instantiate(int anticipatedSize)
>> > {
>> > return new LinkedHashSet<T>();
>> > }
>> >
>> > Perhaps we can lose a little used "feature", no ?
>>
>> No. At least not without a replacement.
>>
>> > On Thu, Nov 16, 2017 at 10:00 PM, Michael Powell <x...@gmail.com>
>>
>> > wrote:
>> >>
>> >> FWIW, *that I know of*, I sometimes use ordered sets, *I THINK*, in
>> >> places. If it's the same collection? I don't know whether it is. It's
>> >> been a little while for me since I am in another code base ATM.
>> >>
>> >> On Thu, Nov 16, 2017 at 7:56 PM, Ricardo Peres <rjpe...@gmail.com>
>> >> wrote:
>> >> > Hola, Fabio!
>> >> >
>> >> > Go for it! Let's kill Iesi.Collection!
>> >> >
>> >> > RP
>> >> >
>> >> >
>> >> > On Thursday, November 16, 2017 at 1:11:49 AM UTC, Fabio Maulo wrote:
>> >> >>
>> >> >> Hi tobarish,
>> >> >>
>> >> >> Can I remove Iesi.Collection dependency ?
>> >> >> with a PR of course.
>> >> >>
>> >> >> @hazzik have you time to help me with some rule about coding style,
>> >> >> rebase, run-all-tests and/or other rules ? Thanks.
>> >> >>
>> >> >>
>> >> > --
>> >> >
>> >> > ---
>> >> > You received this message because you are subscribed to the Google
>> >> > Groups
>> >> > "nhibernate-development" group.
>> >> > To unsubscribe from this group and stop receiving emails from it,
>> >> > send
>> >> > an
>> >> > email to nhibernate-development+unsubscr...@googlegroups.com.
>> >> > For more options, visit https://groups.google.com/d/optout.
>> >>
>> >> --
>> >>
>> >> ---
>> >> You received this message because you are subscribed to the Google
>> >> Groups
>> >> "nhibernate-development" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send
>> >> an
>> >> email to nhibernate-development+unsubscr...@googlegroups.com.
>> >> For more options, visit https://groups.google.com/d/optout.
>> >
>> >
>> >
>> >
>> > --
>> > Fabio Maulo
>> > T @fabiomaulo
>> > S fabiomaulo
>> >
>> > --
>> >
>> > ---
>> > You received this message because you are subscribed to the Google
>> > Groups
>> > "nhibernate-development" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an
>> > email to nhibernate-development+unsubscr...@googlegroups.com.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "nhibernate-development" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to nhibernate-development+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
>
>
> --
> Fabio Maulo
> T @fabiomaulo
> S fabiomaulo
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "nhibernate-development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to nhibernate-development+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
---
You received this message because you are subscribed to the Google Groups
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to nhibernate-development+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
