Hi Tom, On Wed, Jan 13, 2016 at 6:43 PM, Tom Hughes <[email protected]> wrote: > On 13/01/16 13:09, Piotr Popieluch wrote: >> >> >> >> On Wed, Jan 13, 2016 at 12:45 PM, Tom Hughes <[email protected] >> <mailto:[email protected]>> wrote: >> >> On 13/01/16 11:43, [email protected] >> <mailto:[email protected]> wrote: >> >> From 393558883ad677a3e3b6dcb74ce42a189d712576 Mon Sep 17 >> 00:00:00 2001 >> From: Parag Nemade <[email protected] >> <mailto:[email protected]>> >> >> Date: Wed, 13 Jan 2016 10:43:33 +0530 >> Subject: Specify exclusively arch list as per nodejs packaging >> guidelines >> >> --- >> nodejs-deep-extend.spec | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/nodejs-deep-extend.spec b/nodejs-deep-extend.spec >> index e34ec94..dbe09a0 100644 >> --- a/nodejs-deep-extend.spec >> +++ b/nodejs-deep-extend.spec >> @@ -5,14 +5,14 @@ >> >> Name: nodejs-%{module_name} >> Version: 0.3.2 >> -Release: 1%{?dist} >> +Release: 2%{?dist} >> Summary: Recursive object extending >> >> License: MIT >> URL: https://github.com/unclechu/node-deep-extend >> Source0: >> >> http://registry.npmjs.org/%{module_name}/-/%{module_name}-%{version}.tgz >> BuildArch: noarch >> -ExclusiveArch: %{nodejs_arches} noarch >> +ExclusiveArch: %{ix86} x86_64 %{arm} noarch >> >> >> This is the exact opposite of what the guidelines say surely? >> >> The whole point of adding the nodejs_arches macro was to avoid >> having the list of supported architectures embedded in all the spec >> files, so >> that they could be extended in future without changing every spec. >> >> >> This macros is unavailable on el6. (but is available on epel7 and all >> active Fedora branches). >> >> I'm using: >> >> %if 0%{?rhel} == 6 >> ExclusiveArch: %{ix86} x86_64 %{arm} noarch >> %else >> ExclusiveArch: %{nodejs_arches} noarch >> %endif >> >> >> The previous version of the guidelines had an conditional on rhel >> (without version), I don't know why it is removed. > > > But that commit was on the epel7 branch wasn't it? Which should have the > macro? >
Yes you are right. The guidelines are not clear. I am not sure if someone removed EPEL7 specific information but as of these days I am not able to find that information in the nodejs packaging guidelines. Therefore, I started adding dependency generator, expanded macro to epel7 as well. The problem I found is that if I use that macro and build the package then only srpm will appear in epel srpm repository and corresponding binary noarch rpm will not get composed in repository at all. See this ticket https://fedorahosted.org/rel-eng/ticket/6323 Regards, Parag. _______________________________________________ nodejs mailing list [email protected] http://lists.fedoraproject.org/admin/lists/[email protected]
