ctubbsii commented on a change in pull request #366: ACCUMULO-4779 Speedup
Property by precomputing and avoiding sync
URL: https://github.com/apache/accumulo/pull/366#discussion_r163950613
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -629,6 +633,11 @@ public String getRawDefaultValue() {
* @return default value
*/
public String getDefaultValue() {
+ Preconditions.checkState(defaultValueComputed);
Review comment:
I prefer throwing AssertionError if this is a check against a future
programmer error, rather than a protection against a state that the system
could find itself in for an unspecified reason. But, it's not a blocker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
