ctubbsii commented on a change in pull request #366: ACCUMULO-4779 Speedup
Property by precomputing and avoiding sync
URL: https://github.com/apache/accumulo/pull/366#discussion_r163957225
##########
File path: core/src/test/java/org/apache/accumulo/core/conf/PropertyTest.java
##########
@@ -152,4 +153,57 @@ public void validatePropertyKeys() {
public void testGCDeadServerWaitSecond() {
assertEquals("1h", Property.GC_WAL_DEAD_SERVER_WAIT.getDefaultValue());
}
+
+ @SuppressWarnings("deprecation")
Review comment:
Rather than suppress warnings across the entire method, it's better to only
suppress the one case in the method that is deprecated. This avoids masking
future un-triaged warnings.
Here, the `Property.INSTANCE_DFS_URI` can be assigned to a variable of type
Property just before its corresponding `assertTrue` line, and the assignment
can be suppressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
