ctubbsii commented on a change in pull request #366: ACCUMULO-4779 Speedup
Property by precomputing and avoiding sync
URL: https://github.com/apache/accumulo/pull/366#discussion_r164005780
##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -629,6 +633,11 @@ public String getRawDefaultValue() {
* @return default value
*/
public String getDefaultValue() {
+ Preconditions.checkState(defaultValueComputed);
+ return computedDefaultValue;
+ }
+
+ private void precomputeDefaultValue() {
Review comment:
Interesting that the static block runs after the constructors. I guess enum
instances are like `private static final MyClass NAME = new MyClass()` in that
way? But I thought even those ran after other static initializers. Maybe order
matters. Best not to think about it. I think I'll leave Java class
initialization above my head.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
