ctubbsii commented on a change in pull request #366: ACCUMULO-4779 Speedup Property by precomputing and avoiding sync URL: https://github.com/apache/accumulo/pull/366#discussion_r163950956
########## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ########## @@ -589,7 +591,9 @@ ; - private String key, defaultValue, description; + private String key, defaultValue, computedDefaultValue, description; + private boolean annotationsComputed = false, defaultValueComputed = false; + private boolean isSensitive, isDeprecated, isExperimental, isInterpolated; Review comment: This is a tiny thing, and I realize we had this there before... but I'm not generally a fan of multiple declarations. It's cleaner to declare one variable per line... it's easier to see which keywords apply. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
