ctubbsii commented on a change in pull request #1579: Closes #1576: Update
importTable with directory list as Set<String>
URL: https://github.com/apache/accumulo/pull/1579#discussion_r405008459
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -176,11 +176,27 @@ void create(String tableName, NewTableConfiguration ntc)
*
* @param tableName
* Name of a table to create and import into.
- * @param importDir
- * Directory that contains the files copied by distcp from
exportTable
+ * @param importDirs
+ * A comma-delimited list of directories containing the files
copied by distcp from
+ * exportTable
* @since 1.5.0
+ *
+ * @deprecated since 2.1.0 use {@link #importTable(String, Set)} instead.
+ */
+ @Deprecated
Review comment:
> Hmm, I don't understand why adding a new method eliminates the need for
deprecation.
The deprecation has nothing to do with the addition of the new method. It
pertains to the removal of the old method.
> The idea here would be to remove the original `importTable(String,
String)` at some point when it is safe to do so.
If you think it's better to remove the old method, that's fine and it should
be deprecated. It's just not a requirement to remove it.
> @Deprecated(since="2.1.0",forRemoval=true)
If it is going to be deprecated, I agree it should be marked this way. I
don't think we ever want to deprecate something and still retain it forever.
The reason we deprecate stuff is so we can purge it (eventually). I wish
`forRemoval=true` were default when they added this, because that's how I've
always interpreted `@Deprecated`, but I recognize others may interpret it
differently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
