keith-turner commented on a change in pull request #1579: Closes #1576: Update
importTable with directory list as Set<String>
URL: https://github.com/apache/accumulo/pull/1579#discussion_r405089447
##########
File path:
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
##########
@@ -176,11 +176,27 @@ void create(String tableName, NewTableConfiguration ntc)
*
* @param tableName
* Name of a table to create and import into.
- * @param importDir
- * Directory that contains the files copied by distcp from
exportTable
+ * @param importDirs
+ * A comma-delimited list of directories containing the files
copied by distcp from
+ * exportTable
* @since 1.5.0
+ *
+ * @deprecated since 2.1.0 use {@link #importTable(String, Set)} instead.
+ */
+ @Deprecated
Review comment:
> I suppose I'm in favor of keeping the number of public api methods to a
minimum
That is a good goal, not sure whats best in the big scheme of things. In
my experience removing methods is most painful for indirect users of Accumulo
(like someone using Accumulo via something like Rya). Can get into a situation
where you can not use the latest version of Accumulo w/o patching and
rebuilding Rya.
Could minimize clutter in the Accumulo source using a default method in the
interface for the existing method (that calls the new method) and have it
nowhere else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
