keith-turner commented on a change in pull request #1579: Closes #1576: Update 
importTable with directory list as Set<String>
URL: https://github.com/apache/accumulo/pull/1579#discussion_r405047900
 
 

 ##########
 File path: 
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
 ##########
 @@ -176,11 +176,27 @@ void create(String tableName, NewTableConfiguration ntc)
    *
    * @param tableName
    *          Name of a table to create and import into.
-   * @param importDir
-   *          Directory that contains the files copied by distcp from 
exportTable
+   * @param importDirs
+   *          A comma-delimited list of directories containing the files 
copied by distcp from
+   *          exportTable
    * @since 1.5.0
+   *
+   * @deprecated since 2.1.0 use {@link #importTable(String, Set)} instead.
+   */
+  @Deprecated
 
 Review comment:
   > Hmm, I don't understand why adding a new method eliminates the need for 
deprecation.
   
   I was just thinking that adding the new method does not necessitate 
deprecating the existing one.  The existing method is not broken in any way, it 
still satisfies its original functionality for anyone who invested the time to 
write code against it in the past.     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to