milleruntime commented on pull request #1774: URL: https://github.com/apache/accumulo/pull/1774#issuecomment-726416569
@ctubbsii @keith-turner Do you think the class TServerInstance needs to be serializable? We have a transient field declared and are overriding the java serilazation methods but I can't find where we are serializing the object. https://github.com/apache/accumulo/blob/bfe173ec140f07086b0ff8940fc08d640b9539a7/server/base/src/main/java/org/apache/accumulo/server/master/state/TServerInstance.java#L45-L46 I am wondering if this was done because the old Guava object that HostAndPort was taken from at some point was not serializable. https://github.com/apache/accumulo/blob/bfe173ec140f07086b0ff8940fc08d640b9539a7/server/base/src/main/java/org/apache/accumulo/server/master/state/TServerInstance.java#L125-L133 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
