ctubbsii commented on pull request #1774: URL: https://github.com/apache/accumulo/pull/1774#issuecomment-728158049
> @ctubbsii @keith-turner Do you think the class TServerInstance needs to be serializable? We have a transient field declared and are overriding the java serilazation methods but I can't find where we are serializing the object. I found one place where it is serialized as part of a FaTE RepO: `ShutdownTServer` has a member field called `server` of type `TServerInstance`. However, I did notice that it the customizations we've done to serialize and deserialize the `HostAndPort` transient member is because of the comment that says that type isn't serializable. However, the type we're using (the one copied into our code base from Guava) actually *is* serializable. So, we can probably just remove those customization methods, bump the `serialVersionUid` to `2L`, and make the `HostAndPort location` field `final` and remove the `transient` keyword. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
