ctubbsii commented on a change in pull request #1774:
URL: https://github.com/apache/accumulo/pull/1774#discussion_r524648022
##########
File path:
server/manager/src/main/java/org/apache/accumulo/master/MasterClientServiceHandler.java
##########
@@ -278,7 +278,9 @@ public void shutdownTabletServer(TInfo info, TCredentials
c, String tabletServer
log.debug("Seeding FATE op to shutdown " + tabletServer + " with tid " +
tid);
- master.fate.seedTransaction(tid, new TraceRepo<>(new
ShutdownTServer(doomed, force)), false);
+ master.fate.seedTransaction(tid,
+ new TraceRepo<>(new ShutdownTServer(doomed.getHostAndPort(),
doomed.getSession(), force)),
Review comment:
The constructor can still use this type, since that won't affect
serialization. The fields can be derived from the constructor parameter, rather
than passed in as separate parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
