milleruntime commented on pull request #1774: URL: https://github.com/apache/accumulo/pull/1774#issuecomment-728347378
> Actually, since `ShutdownTServer` looks like it's the only place where it is ever serialized, I'd probably prefer to drop `Serializable` altogether (still make the HostAndPort field final), and change `ShutdownTServer`'s serialization to use Strings instead. There's no reason we need to maintain serialization compatibility for `TServerLocation` when it's only ever serialized once, out of over 500 references in the code base. In b735d2291bc59c416c I dropped the serialization of TServerInstance and made `ShutdownTServer` serialize HostAndPort and String instead. I thought this was better since HostAndPort is actually serializable but is not using custom code. Using the HostAndPort in `ShutdownTServer` made it easier to reconstruct `TServerInstance` in the FATE Operation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
