keith-turner commented on a change in pull request #2185:
URL: https://github.com/apache/accumulo/pull/2185#discussion_r682701847



##########
File path: 
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -142,6 +148,8 @@ public void upgradeMetadata(ServerContext ctx) {
     upgradeRelativePaths(ctx, Ample.DataLevel.USER);
     upgradeDirColumns(ctx, Ample.DataLevel.USER);
     upgradeFileDeletes(ctx, Ample.DataLevel.USER);
+    // special case where old files need to be deleted

Review comment:
       I think the upgrade methods are run as follows.
   
    * `upgradeZookeeper()` is run before the root tablet is loaded.
    * `upgradeRoot()` is run after the root tablet is loaded and before the 
metadata table is loaded.  
    * `upgradeMetadata` is run after the metadata table is loaded and before 
loading user tablets.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to