keith-turner commented on a change in pull request #2185:
URL: https://github.com/apache/accumulo/pull/2185#discussion_r682725416



##########
File path: 
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -726,4 +734,37 @@ static Path resolveRelativeDelete(String oldDelete, String 
upgradeProperty) {
     }
     return new Path(upgradeProperty, 
VolumeManager.FileType.TABLE.getDirectory() + oldDelete);
   }
+
+  /**
+   * Remove old temporary map files to prevent problems during recovery.
+   */
+  static void dropSortedMapWALFiles(VolumeManager vm) {
+    Path recoveryDir = new Path("/accumulo/recovery");

Review comment:
       > o you think using the volumes configured in instance.volumes will be 
enough?
   
   Yeah, could look through all of those.  Could narrow it by calling : 
https://github.com/apache/accumulo/blob/a9100ac35f3d72677b767d7670dfb032c7e7d733/server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java#L180
   
   But I don't think it hurts to just look through all volumes.  Maybe could 
use 
https://github.com/apache/accumulo/blob/a9100ac35f3d72677b767d7670dfb032c7e7d733/server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java#L196
 to get the list of volumes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to