milleruntime commented on a change in pull request #2185:
URL: https://github.com/apache/accumulo/pull/2185#discussion_r682691549
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -142,6 +148,8 @@ public void upgradeMetadata(ServerContext ctx) {
upgradeRelativePaths(ctx, Ample.DataLevel.USER);
upgradeDirColumns(ctx, Ample.DataLevel.USER);
upgradeFileDeletes(ctx, Ample.DataLevel.USER);
+ // special case where old files need to be deleted
Review comment:
No, I didn't think any tables were loaded until after the Upgrader was
finished. If that is the case, then moving it to `upgradeZookeeper` would be
better.
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -726,4 +734,37 @@ static Path resolveRelativeDelete(String oldDelete, String
upgradeProperty) {
}
return new Path(upgradeProperty,
VolumeManager.FileType.TABLE.getDirectory() + oldDelete);
}
+
+ /**
+ * Remove old temporary map files to prevent problems during recovery.
+ */
+ static void dropSortedMapWALFiles(VolumeManager vm) {
+ Path recoveryDir = new Path("/accumulo/recovery");
Review comment:
Good catch. I will create a follow on ticket with this and any other
suggestions you have.
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -142,6 +148,8 @@ public void upgradeMetadata(ServerContext ctx) {
upgradeRelativePaths(ctx, Ample.DataLevel.USER);
upgradeDirColumns(ctx, Ample.DataLevel.USER);
upgradeFileDeletes(ctx, Ample.DataLevel.USER);
+ // special case where old files need to be deleted
Review comment:
Ah OK. I will move it to `upgradeZookeeper()`.
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -726,4 +734,37 @@ static Path resolveRelativeDelete(String oldDelete, String
upgradeProperty) {
}
return new Path(upgradeProperty,
VolumeManager.FileType.TABLE.getDirectory() + oldDelete);
}
+
+ /**
+ * Remove old temporary map files to prevent problems during recovery.
+ */
+ static void dropSortedMapWALFiles(VolumeManager vm) {
+ Path recoveryDir = new Path("/accumulo/recovery");
Review comment:
Do you think using the volumes configured in `instance.volumes` will be
enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
