ctubbsii commented on a change in pull request #2185:
URL: https://github.com/apache/accumulo/pull/2185#discussion_r682888910
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader9to10.java
##########
@@ -726,4 +734,37 @@ static Path resolveRelativeDelete(String oldDelete, String
upgradeProperty) {
}
return new Path(upgradeProperty,
VolumeManager.FileType.TABLE.getDirectory() + oldDelete);
}
+
+ /**
+ * Remove old temporary map files to prevent problems during recovery.
+ */
+ static void dropSortedMapWALFiles(VolumeManager vm) {
+ Path recoveryDir = new Path("/accumulo/recovery");
Review comment:
> Would probably be best to avoid choosable() as that will give the
volumes configured for new WALs. The config could change and an old WAL could
be on a volume that choosable() no longer returns. So probably best to inspect
all volumes looking for old sorted wals to nuke.
Definitely avoid this. Consider RandomVolumeChooser :smiley_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
