EdColeman commented on a change in pull request #2305:
URL: https://github.com/apache/accumulo/pull/2305#discussion_r736641013
##########
File path:
server/manager/src/main/java/org/apache/accumulo/manager/metrics/fate/FateMetrics.java
##########
@@ -123,16 +123,16 @@ private void update(MeterRegistry registry) {
}
metricValues.getOpTypeCounters().forEach((name, count) -> {
Review comment:
Thinking about how these tage would look when reported - would it help
consistency if the names were normalized with toLower or toUpper? I don't
recall what they look like - and how that looks compared to "standards"
Previously they were kind of a mess and just an attempt - maybe there's room
for improvement now? With the micrometer translation, maybe we can move to a
more consistent approach? I think it would depend on how these look as
reported by the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
