EdColeman commented on code in PR #3140:
URL: https://github.com/apache/accumulo/pull/3140#discussion_r1063581599
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -746,6 +746,8 @@ public enum Property {
"The number of threads used to delete RFiles and write-ahead logs",
"1.3.5"),
GC_TRASH_IGNORE("gc.trash.ignore", "false", PropertyType.BOOLEAN,
"Do not use the Trash, even if it is configured.", "1.5.0"),
+ GC_TRASH_IGNORE_IMPORTS_ONLY("gc.trash.ignore.imports.only", "false",
PropertyType.BOOLEAN,
+ "Skip trash only for Import files when gc.trash.ignore is true.",
"3.0.0"),
Review Comment:
I find this confusing, Just from the descriptions, if the system is
configured to use trash - then setting GC_TRASH_IGNORE = true overrides the
system setting and files are not moved to trash and are immediately deleted.
With GC_TRASH_IGNORE=true, setting GC_TRASH_IGNORE_IMPORTS_ONLY=true - then
bulk import files skip the trash, but all other files will use the trash?
Would it be easier for users if these were more independent?
- GC_TRASH_IGNORE true - skip trash, false - use trash if configured for the
system.
- GC_TRASH_IGNORE_IMPORTS_ONLY - true - skip trash for bulk import files,
overrides any GC_TRASH_IGNORE setting for bulk import files. false - use
GC_TRASH_IGNORE or the system setting.
My thinking is along the lines of:
| system | GC_TRASH_IGNORE | GC_TRASH_IGNORE_IMPORTS_ONLY | impact
|
|---------------|-----------------|------------------------------|-----------------------|
| trash disable | n/a | n/a | skip
trash, all files |
| trash enabled | N | N | ues
trash, all files |
| trash enabled | N | Y | skip trash, bulk only |
| trash enabled | Y | N | skip trash, all files |
| trash enabled | Y | Y | skip trash, all files |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
