EdColeman commented on code in PR #3140:
URL: https://github.com/apache/accumulo/pull/3140#discussion_r1063600680


##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -746,6 +746,8 @@ public enum Property {
       "The number of threads used to delete RFiles and write-ahead logs", 
"1.3.5"),
   GC_TRASH_IGNORE("gc.trash.ignore", "false", PropertyType.BOOLEAN,
       "Do not use the Trash, even if it is configured.", "1.5.0"),
+  GC_TRASH_IGNORE_IMPORTS_ONLY("gc.trash.ignore.imports.only", "false", 
PropertyType.BOOLEAN,
+      "Skip trash only for Import files when gc.trash.ignore is true.", 
"3.0.0"),

Review Comment:
   That's fine too - but that requires property upgrade code to translate the 
settings - and may have issues because we may need to deprecate, but keep 
GC_TRASH_IGNORE around for a while? Not sure...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to