EdColeman commented on code in PR #3140:
URL: https://github.com/apache/accumulo/pull/3140#discussion_r1063591647
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -746,6 +746,8 @@ public enum Property {
"The number of threads used to delete RFiles and write-ahead logs",
"1.3.5"),
GC_TRASH_IGNORE("gc.trash.ignore", "false", PropertyType.BOOLEAN,
"Do not use the Trash, even if it is configured.", "1.5.0"),
+ GC_TRASH_IGNORE_IMPORTS_ONLY("gc.trash.ignore.imports.only", "false",
PropertyType.BOOLEAN,
+ "Skip trash only for Import files when gc.trash.ignore is true.",
"3.0.0"),
Review Comment:
That's what I ran into too - but renaming the GC_TRASH_IGNORE property
seemed something to be avoided. Maybe if the new property was
`GC_TRASH_IGNORE_IMPORTS` - that would make having the usage I described above
easier to communicate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
