dlmarion commented on code in PR #3140:
URL: https://github.com/apache/accumulo/pull/3140#discussion_r1063597186
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -746,6 +746,8 @@ public enum Property {
"The number of threads used to delete RFiles and write-ahead logs",
"1.3.5"),
GC_TRASH_IGNORE("gc.trash.ignore", "false", PropertyType.BOOLEAN,
"Do not use the Trash, even if it is configured.", "1.5.0"),
+ GC_TRASH_IGNORE_IMPORTS_ONLY("gc.trash.ignore.imports.only", "false",
PropertyType.BOOLEAN,
+ "Skip trash only for Import files when gc.trash.ignore is true.",
"3.0.0"),
Review Comment:
```
GC_USE_TRASH("gc.trash.ignore", "true", PropertyType.BOOLEAN,
"If trash is configured, move deleted non-bulk import files there
instead of deleting them", "1.5.0"),
GC_BULK_IMPORT_USE_TRASH("gc.trash.use.bulk.imports", "true",
PropertyType.BOOLEAN,
"If trash is configured, move deleted bulk import files there instead
of deleting them", "3.0.0"),
```
| Trash Enabled | GC_USE_TRASH | GC_BULK_IMPORT_USE_TRASH | Result |
|----------------------|------------------------|-----------------------------------------------|-----------|
| N | N/A | N/A | all files deleted |
| Y | true | true | all files moved to trash |
| Y | false | true | only bulk import files moved to trash |
| Y | true | false | bulk import files deleted , others moved to trash |
| Y | false | false | all files deleted |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
