ctubbsii commented on code in PR #3140:
URL: https://github.com/apache/accumulo/pull/3140#discussion_r1132301179
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -746,6 +746,8 @@ public enum Property {
"The number of threads used to delete RFiles and write-ahead logs",
"1.3.5"),
GC_TRASH_IGNORE("gc.trash.ignore", "false", PropertyType.BOOLEAN,
"Do not use the Trash, even if it is configured.", "1.5.0"),
+ GC_TRASH_IGNORE_IMPORTS_ONLY("gc.trash.ignore.imports.only", "false",
PropertyType.BOOLEAN,
+ "Skip Trash for Import files when the trash is in use.", "3.0.0"),
Review Comment:
Yes, that's what I was thinking when I said "third possible value" above.
But, that solution is only good if that is the end of the requirements to
expand this behavior and the number of configurable values stops at three. If
the requirements expand to support additional use cases, then it would be
better to make this behavior a pluggable policy than to enumerate a long list
of possible values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
