cshannon commented on PR #3417: URL: https://github.com/apache/accumulo/pull/3417#issuecomment-1557160881
All IT tests passed now. Also something else I thought of would it would be nice to add a new interface and rename `TabletFile`. Right now `UnreferencedTabletFile`, `StoredTabletFile` extend `AbstractTabletFile`. I think this is fine but it would be nicer/more clear to rename the existing `TabletFile` to `ReferencedTabletFile` and create a `TabletFile` interface. So you'd have: ``` //new interface TabletFile interface (contains some method definitions like getPath() or getFileName()) //Abstract class implements the interface AbstractTabletFile implements TabletFile ``` ``` //Concrete classes //renamed existing TabletFile ReferencedTabletFile extends AbstractTabletFile StoredTabletFile extends AbstractTabletFile UnreferencedTabletFile extends AbstractTabletFile ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
