cshannon commented on code in PR #3417:
URL: https://github.com/apache/accumulo/pull/3417#discussion_r1206760772
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -60,6 +65,22 @@ public Text getMetaUpdateDeleteText() {
return new Text(getMetaUpdateDelete());
}
+ public TabletFile getTabletFile() {
+ return tabletFile;
+ }
+
+ public TableId getTableId() {
+ return tabletFile.getTableId();
+ }
+
+ public String getPathStr() {
+ return tabletFile.getPathStr();
+ }
+
+ public Text getMetaInsertText() {
+ return tabletFile.getMetaInsertText();
+ }
Review Comment:
So for this I have the same comment as I had with adding a putFile() method
that takes a StoredTabletFile.
In this existing code this is used and we always normalize where this is
[called](https://github.com/apache/accumulo/blob/0017fd8949cc1bc7253b8e90313d4fd1b71e2241/server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java#L261).
So, we are normalizing today even for StoredTabletFile and I'm wondering
what happens if we don't. Is this actually bug and we are using the wrong value
but it's not showing up as the normalized path usually equals the existing path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
