cshannon commented on code in PR #3417:
URL: https://github.com/apache/accumulo/pull/3417#discussion_r1206747658
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/bulkVer2/LoadFiles.java:
##########
@@ -219,7 +221,8 @@ void load(List<TabletMetadata> tablets, Files files) {
server = location.getHostAndPort();
}
- Set<TabletFile> loadedFiles = tablet.getLoaded().keySet();
+ Set<TabletFile> loadedFiles = tablet.getLoaded().keySet().stream()
Review Comment:
I think you are right so this help things be more clear now that we don't
need to rely on that sketchy equals anymore.
Before the change, `StoredTabletFile` always just delegated to the
`TabletFile` for equals/hashcode (which uses the normalized path for
comparison). Now, since we are mapping the set of StoredTabletFiles to a set of
TabletFiles, it will just always compare TabletFile to TabletFile which will
still use the normalized path as before so the equals is the same but we don't
have to rely on StoredTabletFile not implementing a proper equals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
