dlmarion commented on code in PR #3417:
URL: https://github.com/apache/accumulo/pull/3417#discussion_r1205389542
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -71,4 +92,40 @@ public void validate(String reference) {
+ " does not match what was in the metadata: " + metadataEntry);
}
}
+
+ @Override
+ public int compareTo(StoredTabletFile o) {
+ if (equals(o)) {
+ return 0;
+ } else {
+ return metadataEntry.compareTo(o.metadataEntry);
+ }
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ StoredTabletFile that = (StoredTabletFile) o;
+ return Objects.equals(metadataEntry, that.metadataEntry);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(metadataEntry);
+ }
+
+ @Override
+ public String toString() {
+ return metadataEntry;
Review Comment:
Same comment goes for UnreferencedTabletFile.toString
##########
core/src/main/java/org/apache/accumulo/core/metadata/StoredTabletFile.java:
##########
@@ -71,4 +92,40 @@ public void validate(String reference) {
+ " does not match what was in the metadata: " + metadataEntry);
}
}
+
+ @Override
+ public int compareTo(StoredTabletFile o) {
+ if (equals(o)) {
+ return 0;
+ } else {
+ return metadataEntry.compareTo(o.metadataEntry);
+ }
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ StoredTabletFile that = (StoredTabletFile) o;
+ return Objects.equals(metadataEntry, that.metadataEntry);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(metadataEntry);
+ }
+
+ @Override
+ public String toString() {
+ return metadataEntry;
Review Comment:
Wondering if TabletFile.toString() and this would ever be equivalent. If
they could be, should we add something to the toString() output that makes them
different in case there is code that is comparing the toString output for
equivalence instead of using equals()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
