dlmarion commented on code in PR #3626:
URL: https://github.com/apache/accumulo/pull/3626#discussion_r1272401168
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -194,10 +211,24 @@ Map<String,String>
modifyProperties(Consumer<Map<String,String>> mapMutator)
* @param tserver The tablet server address. This should be of the form
* {@code <ip address>:<port>}
* @return A list of active scans on tablet server.
+ * @deprecated see {@link #getActiveScans(Server)}
*/
+ @Deprecated(since = "3.0.0")
List<ActiveScan> getActiveScans(String tserver)
throws AccumuloException, AccumuloSecurityException;
+ /**
+ * List the active scans on a tablet server.
+ *
+ * @param server server type and address
+ * @return A collection of active scans on tablet server.
+ * @since 3.0.0
+ * @throws IllegalArgumentException when the type of the server is not
TABLET_SERVER or
+ * SCAN_SERVER
Review Comment:
I think this would cause too much churn between 3.0 and 4.0. For example, I
could create an interface `CompactingServer` and modify CompactorServerId and
TabletServerId to implement it, then modify the
`InstanceOperations.getActiveCompactions` to only accept an instance of
`CompactingServer`. However, in 4.0, I would have to remove the
`CompactingServer` interface from `TabletServerId` as compactions only occur in
Compactors in that branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
