dlmarion commented on code in PR #3626:
URL: https://github.com/apache/accumulo/pull/3626#discussion_r1272290118
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java:
##########
@@ -236,12 +253,67 @@ public List<String> getTabletServers() {
}
@Override
+ public Set<Server> getServers(ServerType type) {
Review Comment:
If I use the Predicate then I have to test against every single server each
time this is called, right? This is replacing `getTabletServers`,
`getScanServers` and `getManagerLocations`. If the user want's everything, then
I think it makes sense that they call this method N times instead of us
gathering all of the information every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
