keith-turner commented on code in PR #3626:
URL: https://github.com/apache/accumulo/pull/3626#discussion_r1269933858
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -172,20 +174,31 @@ Map<String,String>
modifyProperties(Consumer<Map<String,String>> mapMutator)
* @return a list of locations in <code>hostname:port</code> form.
* @since 2.1.0
*/
+ @Deprecated
List<String> getManagerLocations();
/**
* Returns the locations of the active scan servers
*
* @return A set of currently active scan servers.
*/
+ @Deprecated
Set<String> getScanServers();
+ /**
+ * Returns the locations of the active scan servers
+ *
+ * @return A set of currently active scan servers.
+ * @since 3.0.0
+ */
+ Set<Server> getServers(ServerType type);
Review Comment:
May make sense to defer adding the resourceGroup to the server type to the
elasticity branch. Could still add these new types in 3.x and not have the
resource group method in 3.0. Thinking if we release something in 3.x that
still may still change in the elasticity branch that it could cause problems if
it does change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
