dlmarion commented on code in PR #3626:
URL: https://github.com/apache/accumulo/pull/3626#discussion_r1269380910
##########
core/src/main/java/org/apache/accumulo/core/client/admin/InstanceOperations.java:
##########
@@ -172,20 +174,31 @@ Map<String,String>
modifyProperties(Consumer<Map<String,String>> mapMutator)
* @return a list of locations in <code>hostname:port</code> form.
* @since 2.1.0
*/
+ @Deprecated
List<String> getManagerLocations();
/**
* Returns the locations of the active scan servers
*
* @return A set of currently active scan servers.
*/
+ @Deprecated
Set<String> getScanServers();
+ /**
+ * Returns the locations of the active scan servers
+ *
+ * @return A set of currently active scan servers.
+ * @since 3.0.0
+ */
+ Set<Server> getServers(ServerType type);
Review Comment:
My comment is that the name `resourceGroup` is a little before it's time. In
2.1 ScanServers have groups and Compactors have queues, which is what will be
returned here for 3.0. In elasticity as you know, we have centralized on the
name `group` in the properties and code, and I have been calling the feature
`resource groups` as `groups` is too vague and the way that they are intended
to be used is to create groups of resources dedicated to running
tservers/sservers/compactors for specific use-cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
