DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1323161770
##########
pages/downloads.md:
##########
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' | append: linkVers | append: '-' | append:
srcbin | append: '.tar.gz' %}
{% assign lnkSuffix = '/accumulo/' | append: linkVers | append: '/' | append:
lnkFile %}
-<div class="row btn-group" style="margin-left: 20px; margin-bottom: 5px;
display: block">
- <div class="col btn-group">
+<div class="row" style="margin-left: 20px; margin-bottom: 5px;">
+ <div class="btn-group col-auto">
<a {{btnDownloadStyle}} href="{{closerLink}}{{lnkSuffix}}"
link-suffix="{{lnkSuffix}}">{{lnkFile}}{{glyphSave}}</a>
- </div><div class="col btn-group">
- <a {{btnSigStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
- <a {{btnHashStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+ <div class="btn-group">
+ <a {{btnSigStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
+ <a {{btnHashStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+ </div>
Review Comment:
> The old buttons were lighter, and had mouse-over effects that made them
slightly darker as a highlight before you click them.
Here is how the new buttons behave:
> the ASC and SHA buttons seem to blend together. In the old version, they
had a clear border
I noticed this as well but that seems to be the new bootstrap default. There
are classes like `btn-outline-secondary` that have a light background and the
outline and text is of the secondary color (see example below) but not sure if
thats something we want to do. We could also override the button styles as you
suggested in the other comment.
> the lock icons probably need a between ASC and the icon and between
SHA and the icon
This is how the code is now in this branch. `{% assign glyphSave =
' <span class="fa-solid fa-cloud-arrow-down"></span>' %}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
