ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1323383310
##########
pages/downloads.md:
##########
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' | append: linkVers | append: '-' | append:
srcbin | append: '.tar.gz' %}
{% assign lnkSuffix = '/accumulo/' | append: linkVers | append: '/' | append:
lnkFile %}
-<div class="row btn-group" style="margin-left: 20px; margin-bottom: 5px;
display: block">
- <div class="col btn-group">
+<div class="row" style="margin-left: 20px; margin-bottom: 5px;">
+ <div class="btn-group col-auto">
<a {{btnDownloadStyle}} href="{{closerLink}}{{lnkSuffix}}"
link-suffix="{{lnkSuffix}}">{{lnkFile}}{{glyphSave}}</a>
- </div><div class="col btn-group">
- <a {{btnSigStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
- <a {{btnHashStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+ <div class="btn-group">
+ <a {{btnSigStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
+ <a {{btnHashStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+ </div>
Review Comment:
Oh, I like the outline variant. Let's go with that one. Much easier to not
have to mess with colors. I still think we need to add some padding between the
button groups, though. They're a bit mashed up against one another. The spacing
between the bottom row (release notes, readme, etc.) are nice. It'd be nice to
have the same between the download links and the checksum buttons. The line
between the ASC/SHA buttons are sufficient, though, so we don't need a space
there... it seems the style as a "button group" there is fine (whereas I was
previously thinking it as a "group of buttons" rather than a "button group").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
