DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1323398873
##########
pages/downloads.md:
##########
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' | append: linkVers | append: '-' | append:
srcbin | append: '.tar.gz' %}
{% assign lnkSuffix = '/accumulo/' | append: linkVers | append: '/' | append:
lnkFile %}
-<div class="row btn-group" style="margin-left: 20px; margin-bottom: 5px;
display: block">
- <div class="col btn-group">
+<div class="row" style="margin-left: 20px; margin-bottom: 5px;">
+ <div class="btn-group col-auto">
<a {{btnDownloadStyle}} href="{{closerLink}}{{lnkSuffix}}"
link-suffix="{{lnkSuffix}}">{{lnkFile}}{{glyphSave}}</a>
- </div><div class="col btn-group">
- <a {{btnSigStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
- <a {{btnHashStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+ <div class="btn-group">
+ <a {{btnSigStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
+ <a {{btnHashStyle}}
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+ </div>
Review Comment:
> > This is how the code is now in this branch. `{% assign glyphSave =
' <span class="fa-solid fa-cloud-arrow-down"></span>' %}`
>
> That's for the arrow for the download link. I assume there's a similar for
the ASC/SHA, but it didn't look like it worked in your visualization. Not sure
why.
`{% assign glyphLock = ' <span class="fa-solid fa-lock"></span>' %}`.
The lock icon code has it too. Which visualization doesn't look right?
edit: I think you are looking at the first screencap in this thread with me
showing the difference between the version that properly wraps(first version
for 3.0.0 section) and how it worked before that change (2.x and 1.x sections)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
