[GitHub] [accumulo-website] DomGarguilo commented on a diff in pull request #398: Upgrade bootstrap version from 3 to 5

[via GitHub]

DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1323421620


##########
pages/downloads.md:
##########
@@ -85,26 +85,29 @@ available in a future update to this site.
 {% for srcbin in srcbinArray %}
 {% assign lnkFile = 'accumulo-' | append: linkVers | append: '-' | append: 
srcbin | append: '.tar.gz' %}
 {% assign lnkSuffix = '/accumulo/' | append: linkVers | append: '/' | append: 
lnkFile %}
-<div class="row btn-group" style="margin-left: 20px; margin-bottom: 5px; 
display: block">
-  <div class="col btn-group">
+<div class="row" style="margin-left: 20px; margin-bottom: 5px;">
+  <div class="btn-group col-auto">
     <a {{btnDownloadStyle}} href="{{closerLink}}{{lnkSuffix}}" 
link-suffix="{{lnkSuffix}}">{{lnkFile}}{{glyphSave}}</a>
-  </div><div class="col btn-group">
-    <a {{btnSigStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
-    <a {{btnHashStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+    <div class="btn-group">
+      <a {{btnSigStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.asc">ASC{{glyphLock}}</a>
+      <a {{btnHashStyle}} 
href="{{downloadsLink}}{{lnkSuffix}}.sha512">SHA{{glyphLock}}</a>
+    </div>

Review Comment:
   In bad8a2d I added a slight margin to the right of the download button and 
made the other two buttons the outline style:
   ![Screenshot from 2023-09-12 
14-33-21](https://github.com/apache/accumulo-website/assets/47725857/77da3b24-eef6-40ac-b9b5-f58357d9dc2d)
   And when wrapping:
   ![Screenshot from 2023-09-12 
14-33-35](https://github.com/apache/accumulo-website/assets/47725857/e4485e5b-22db-462b-a71a-9afa7cb31c95)
   
   Alternatively, here is what it would look like for the download button to 
have the outline style too:
   ![Screenshot from 2023-09-12 
14-34-19](https://github.com/apache/accumulo-website/assets/47725857/d4ccfebe-d99c-472f-8e2c-f38ad8a58e5e)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org