dlmarion commented on code in PR #3893:
URL: https://github.com/apache/accumulo/pull/3893#discussion_r1392932679
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletGoalState.java:
##########
@@ -145,6 +146,10 @@ public String getResourceGroup() {
}
}
+ if (VolumeUtil.needsVolumeReplacement(params.getVolumeReplacements(),
tm)) {
Review Comment:
This seems duplicative. We are calling `VolumeUtil.needsVolumeReplacement`
in TabletManagementIterator send returning a `NEEDS_VOLUME_REPLACEMENT` action.
We handle this action in TabletGroupWatcher, so I think we just need to
override the goal state in TGW instead of calling
`VolumeUtil.needsVolumeReplacement` for every tablet every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
