keith-turner commented on code in PR #3893:
URL: https://github.com/apache/accumulo/pull/3893#discussion_r1394382029
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletGoalState.java:
##########
@@ -145,6 +146,10 @@ public String getResourceGroup() {
}
}
+ if (VolumeUtil.needsVolumeReplacement(params.getVolumeReplacements(),
tm)) {
Review Comment:
We could possibly pass a `boolean needsVolumeReplacement` to the
computeGoalState function to avoid computing twice if its actually a
performance issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
