keith-turner commented on code in PR #3893:
URL: https://github.com/apache/accumulo/pull/3893#discussion_r1394396441


##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletGoalState.java:
##########
@@ -145,6 +146,10 @@ public String getResourceGroup() {
         }
       }
 
+      if (VolumeUtil.needsVolumeReplacement(params.getVolumeReplacements(), 
tm)) {

Review Comment:
   Also the goal state needs to be properly computed in the TabletMgmtIter so 
that it will return an action of needs location update in addition to returning 
needs volume replacement.  Need to get tablets unassigned before doing the 
volume update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to