dlmarion commented on code in PR #3893:
URL: https://github.com/apache/accumulo/pull/3893#discussion_r1396272573
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletGoalState.java:
##########
@@ -145,6 +146,10 @@ public String getResourceGroup() {
}
}
+ if (VolumeUtil.needsVolumeReplacement(params.getVolumeReplacements(),
tm)) {
Review Comment:
I think the change I made in b482623 alleviates my concern - guarding the
check for volume replacement depending on the size of the volume replacements
list. This list is empty (see createTabletManagementParameters) when no more
volume replacements are occurring in the TGW. I also added some protection to
make sure that the tablet is unassigned when doing the volume replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
