EdColeman commented on code in PR #4208:
URL: https://github.com/apache/accumulo/pull/4208#discussion_r1476725865
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/tableImport/PopulateMetadataTable.java:
##########
@@ -155,11 +166,7 @@ public Repo<Manager> call(long tid, Manager manager)
throws Exception {
if (m == null || !currentRow.equals(metadataRow)) {
if (m != null) {
- if (!sawTabletAvailability) {
- // add a default tablet availability
- TabletColumnFamily.AVAILABILITY_COLUMN.put(m,
-
TabletAvailabilityUtil.toValue(TabletAvailability.ONDEMAND));
- }
+ AVAILABILITY_COLUMN.put(m,
TabletAvailabilityUtil.toValue(initialAvailability));
Review Comment:
The issue would be if you exported something was HOSTED and then you want to
import when there is not sufficient capacity to support the import as hosted.
For example you moved to a smaller cluster, the existing cluster was down-sized
since the export, or there is not sufficient capacity to have two instances
concurrently HOSTED.
In that case, the import could negativity impact the cluster unless it was
imported as UNHOSTED. It could be easier to:
1. Export the table without availability
2. Import the table, setting the desired state.
This would also make it easier to import files that could have been exported
before elasticity and hosting goals were an option. There would be no need to
check and "guess" a goal if one is not present,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
