dlmarion commented on code in PR #4311:
URL: https://github.com/apache/accumulo/pull/4311#discussion_r1504858785
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -49,42 +51,25 @@ public enum Property {
"Both major and minor compaction properties can be included under this
prefix.", "3.1.0"),
COMPACTION_SERVICE_PREFIX(COMPACTION_PREFIX + "service.", null,
PropertyType.PREFIX,
"This prefix should be used to define all properties for the compaction
services."
- + "See {% jlink -f
org.apache.accumulo.core.spi.compaction.DefaultCompactionPlanner %}.\n"
+ + "See {% jlink -f
org.apache.accumulo.core.spi.compaction.RatioBasedCompactionPlanner %}.\n"
+ "A new external compaction service would be defined like the
following:\n"
+ "`compaction.service.newService.planner="
- +
"\"org.apache.accumulo.core.spi.compaction.DefaultCompactionPlanner\".`\n"
+ +
"\"org.apache.accumulo.core.spi.compaction.RatioBasedCompactionPlanner\".`\n"
+ "`compaction.service.newService.opts.groups=\""
+ "[{\"name\": \"small\", \"maxSize\":\"32M\"},"
Review Comment:
Should 'name' be replaced with 'group' in this example?
##########
server/base/src/main/java/org/apache/accumulo/server/init/InitialConfiguration.java:
##########
@@ -88,9 +91,14 @@ class InitialConfiguration {
initialMetaConf.put(Property.TABLE_COMPACTION_DISPATCHER.getKey(),
SimpleCompactionDispatcher.class.getName());
- initialMetaConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() +
"service", "meta");
+ initialMetaConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() +
"service",
+ DEFAULT_COMPACTION_SERVICE_NAME);
- // TODO configure initial fate table config.. probably needs compaction
config??
+ // ELASTICITY_TODO configure initial fate table config
Review Comment:
Is this TODO still needed? It looks like you are configuring it below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
