ddanielr commented on code in PR #4311:
URL: https://github.com/apache/accumulo/pull/4311#discussion_r1505084401


##########
server/base/src/main/java/org/apache/accumulo/server/init/InitialConfiguration.java:
##########
@@ -51,7 +53,8 @@ class InitialConfiguration {
     this.siteConf = siteConf;
     initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER.getKey(),
         SimpleCompactionDispatcher.class.getName());
-    initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() + 
"service", "root");
+    initialRootConf.put(Property.TABLE_COMPACTION_DISPATCHER_OPTS.getKey() + 
"service",

Review Comment:
   #4289 now validates properties as part of the upgrade, but I'm not sure how 
the compaction properties will be handled. #4273 will remove the need for 
additional properties to be set, but these dispatch opts will still work. 
   
   I'm fine with removing these entirely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to